From: Björn Daase Date: Fri, 24 Jan 2020 18:01:45 +0000 (+0000) Subject: Revert "recorder: Switch to vp9" X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~781^2^2~130 X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=c61685e6170c328ccab43d51464bc4c74669d2e1;p=gnome-shell.git Revert "recorder: Switch to vp9" This reverts commit d183f13456991d12ea57ad14ba38a1f7407d0037. Switching to the vp9 encoder seemed like a good idea at the time but unfortunately it also has the major drawback, that it leaks a serious amount of memory every time it is used. See https://gitlab.gnome.org/GNOME/gnome-shell/issues/256#note_692743 for more details. https://gitlab.gnome.org/GNOME/gnome-shell/issues/256 --- diff --git a/src/shell-recorder.c b/src/shell-recorder.c index 1a318175e..7a01d5fd1 100644 --- a/src/shell-recorder.c +++ b/src/shell-recorder.c @@ -146,7 +146,7 @@ G_DEFINE_TYPE(ShellRecorder, shell_recorder, G_TYPE_OBJECT); /* The default pipeline. */ -#define DEFAULT_PIPELINE "vp9enc min_quantizer=13 max_quantizer=13 cpu-used=5 deadline=1000000 threads=%T ! queue ! webmmux" +#define DEFAULT_PIPELINE "vp8enc min_quantizer=13 max_quantizer=13 cpu-used=5 deadline=1000000 threads=%T ! queue ! webmmux" /* If we can find the amount of memory on the machine, we use half * of that for memory_target, otherwise, we use this value, in kB. @@ -1467,7 +1467,7 @@ shell_recorder_set_draw_cursor (ShellRecorder *recorder, * might be used to send the output to an icecast server * via shout2send or similar. * - * The default value is 'vp9enc min_quantizer=13 max_quantizer=13 cpu-used=5 deadline=1000000 threads=%T ! queue ! webmmux' + * The default value is 'vp8enc min_quantizer=13 max_quantizer=13 cpu-used=5 deadline=1000000 threads=%T ! queue ! webmmux' */ void shell_recorder_set_pipeline (ShellRecorder *recorder,